"And for that, I thank Turnip Trump’s aggressive stance."

Except that he has no aggressive stance. He’s been shouting a lot to give the impression that he’s being "tough on China" but the reality of his foreign policy is that he’s given China more leeway and more concessions than any last five or six presidents before him.
That trade war? Most of the announced tariffs were never implemented – and good thing for the US too, as those would hurt the US by far more than it’d hurt China – so all he’s managed to accomplish is saber-rattling at home to the cost of about 200k jobs and a significant cut in US GDP.

"Traditional foreign political thought was that as we embraced China on the global stage, it would become more democratic. The opposite has happened. And nobody- not Republicans, not Democrats wanted to face the juggernaut that China was becoming."

If US statesmen were ever that naíve the jokes on them. This isn’t the first, second, or tenth time China has made a resurgence as a vibrant power on the world stage through history.
But I don’t think they were that naíve – because no one else was. Instead, skip to the second part of your paragraph about no one wanting to face the chinese juggernaut and add this at the end;
"…nor did any US politician have the chutzpah to go tell their industry they’d have to cut their projected margins in half by not moving the manufacturing offshore."

"Trump made a clear political calculation, throwing red meat to his base so to speak, but it was also the right call. It was the right call long-term economically, politically, and morally."

It might have been if he actually did any of that. Emperor Xi still emerged from this faux "trade war" the hands-down winner. This was carved in stone around mid-2019. And Trump has been running around raising his abject loss to the skies and calling out his "great victory".

And no dearth of gullible fools exist who ate the bullshit he sold them without even fact-checking it. Go google "marketwatch the-trade-war-is-over-and-china-won" for a decent easily read summary of the proceedings. Even some of Trump’s own camp called the result "appeasement and concession".

"Why didn’t Obama do that?"

Not the platform he campaigned on, and to be blunt any president who campaigns on such a platform is a lying bastard. For the US to breed a new golden goose to replace the one they sold to China back in the 80’s will take around three generations of US industry becoming distinctly unprofitable and massive, persistent government subsidies of training a whole new generation of engineers and high-skill factory workers.

"The avoidance of tough issues like supporting Taiwan and Hong Kong was shameful."

Because no one wants an unwinnable war. Hong Kong was chinese soil to begin with and it was clear to everyone back in the 90’s that when it was returned any Hong Kong citizen who didn’t want to be mainland Chinese had better leave. Taiwan would be better off not trying to claim they are China – which is the main contention of the whole dispute anyway.

"You simply can’t engage with them. (I speak as someone having lived there 5 of the last 9 years, and negotiations in good faith will never work considering the dynamics of their politics.)"

Not quite true. You can work with China well enough as long as it’s understood that they aren’t shifting their core values. The western focus on the nonsense of "IP" and the persistent demands of the west that China should cripple it’s own industry to match those of the west are, and will always be, a non-starter.
On lower tiers so much of Chinese commerce goes through networking. If you aren’t part of the social network you aren’t going to get an equitable contract.

And this may come as a surprise to you, given the quality of your assumptions so far – why should China suddenly be the bigger guy and start playing fair when they now do unto you what you did unto them last generation?
Don’t expect fairness where you have given none in the past, dude.

"Biden and the establishment were happy for things to keep going the way they were."

Gonna skip this one since we can just state that Biden and "the establishment" are unable to comprehend and unwilling to sell the US the idea that the next few generations of US citizens will be facing depression while the country re-tools itself to competitively take back manufacturing from China. It’s not that they’re happy. It’s that Biden’s backers in the democratic party are facing a house burning down and now have to make the call on which of the kids they get to carry out. Being politicians they’ll make that call and then pretend the child they couldn’t save never existed. Right now the baby they want to carry out seems to be the US concept of equality and liberty. Not sure I’d trust Sleepy Joe the Windsock with that one, tbh…

"And yea, Trump is an opportunist, and his desire to make a deal and look good means we probably won’t see much meaningful action/results…"

Actually, no. We are seeing results, of a sort. See, the democrats at least try to preserve their veneer of uprightness which means their malfeasance HAS to be less obvious – there must be no obvious harm.
Trump has no such limits so he has, in his brief four years, caused more damage to the US, at home and abroad, than any ten democrat fumblefingers you could name.

"…but without him, our politicians would still be trying to ignore all their bullying and abusive behaviors…"

You didn’t read a single line Obama had to say about China, did you? In 2009 he imposed steep tariffs on select Chinese products for evaluation and the feedback was grim – it hurts the US way more than it does China to start a trade war, even when China, in that case, didn’t even retaliate. So it was already known that a US-China trade war was harmful to the US and a net gain for China in the long run. And yet Trump blithely went into that steel trap for the sake of PR.

Let me posit an alternative suggestion to you; That any political and financial analyst worth their salt knows that there are no good options on the US table. The US painted itself into a corner in the 80’s and there’s no way out which doesn’t require extensive sacrifice by the US citizen. Democrat and republican statesmen who know the politics about this are aware of it and are all in the mode of damage mitigation because they’ve realize that so far the only solutions on the table so far are the sort of cure which kills the patient.

"Its now in the public consciousness that china provides massive subsidies to important industries like solar tech or steel, putting American companies at a severe disadvantage."

You realize that Obama was screaming about this back in 2009? What Trump did was to shoot US industry in the leg and point out that "Hey you’re limping".

"These are issues the average American was unaware of untilll…. Trump."

And he made people aware they were on the brink by shoving them off it. That "silver lining" really isn’t helpful.

What is more, courtesy of him and the current GOP the republicans are now inherently unable to produce a single candidate, assistant or adviser capable of actually fixing the problem.

You don’t have two good options. You don’t even have two bad options. You’ve got two options of which one is just very bad and insufficient – and the other one is a malicious trainwreck guided by a death cult.

Talking about the good effects of Trump’s administration is like highlighting the positive that the Zodiac killer’s murder spree provided much needed public safety awareness.